Repository navigation
chore(docs): update AGENTS.md to reflect recent changes - #291
Conversation
Notes the build-then-exec test pattern plugin-subcommands-advanced uses (tests/older-framework.test.ts) to guard its runtime namespace lookup of runPreconditions, which keeps it working on peer framework releases before 6.3.0, mirroring plugin-opentelemetry's preload-test convention.
|
Note The title starts with
|
There was a problem hiding this comment.
Important
The AGENTS.md change itself is accurate, but the PR title and body break two repository rules that need fixing before merge.
Reviewed changes: the single commit adding one bullet to AGENTS.md.
- New "Conventions" bullet — documents
plugin-subcommands-advanced'stests/older-framework.test.tsas a second instance of the build-then-exec child-process test pattern. I checked it against the test,tests/fixtures/*,getRunPreconditions()insrc/lib/utils/wiring.tsand the package's peer range. Every claim holds.
⚠️ PR title scope docs is not allowed by the semantic PR check
chore(docs): … uses a scope that isn't in the scopes list of .github/workflows/semantic-pull-requests.yml, so that check will fail. AGENTS.md says to omit the scope when a change isn't tied to one package.
Technical details
# PR title scope
## Affected sites
- PR title `chore(docs): update AGENTS.md to reflect recent changes`
- `.github/workflows/semantic-pull-requests.yml:42-58` — allowed scopes are the package names plus `gateway`, `cache`, `sharder`, `deps`, `release`, `ci`.
## Required outcome
- Title passes the semantic PR check.
## Suggested approach
- Retitle to `chore: update AGENTS.md to reflect recent changes` (no scope). The subject must not start with an uppercase letter.⚠️ PR body carries an extra "Generated by Claude Code" footer
The body ends with _Generated by [Claude Code](https://claude.ai/code/session_…)_ after the AI disclosure line. AGENTS.md ("AI disclosure") says the disclosure line is the only AI attribution allowed, with no tool footers or session links and nothing after it.
Technical details
# Extra AI attribution in PR body
## Affected sites
- PR body, last lines: the `---` rule and `_Generated by [Claude Code](...)_` line after `> 🤖 AI disclosure: …`.
## Required outcome
- The body contains exactly one disclosure line (the one defined in `AI_POLICY.md#disclosure`) and nothing after it.
## Suggested approach
- Remove the trailing `---` and `_Generated by …_` lines via `gh pr edit`, then re-check the final body.ℹ️ The new bullet doesn't mention the module-hook shim
The bullet says the loader shows a named import "would fail to link", but not why. The mechanism is tests/fixtures/without-run-preconditions.hooks.mjs, which registers module hooks that serve @wolfstar/http-framework without runPreconditions. Without that, a reader may assume the child process runs against a real older framework. A short clause such as "through a module.register hook shim that strips the export" would close the gap. This is optional.
claude-sonnet-5-5 | 𝕏

🔗 Linked issue
N/A — scheduled weekly
AGENTS.mdmaintenance routine.🧭 Context
Weekly review of pull requests merged into
mainin the last 7 days (#280, #282, #283, #284, #285, #286, #287), checking whetherAGENTS.mdstill accurately documents the repo's conventions.Most of the window's changes already carried their own
AGENTS.mdupdates: #280 (announce workflow) and #288/#285 (opentelemetry dispatch spans, gatewayaddDispatchWrapper/addDestroyHookmoved to module-levelWeakMaps) landed with the relevant notes already in place. #282/#284 (theplugin-subcommands-advancedpreconditions fix and its older-framework regression test) did not add a note, and the new test establishes a reusable pattern — a second instance of the build-then-exec-in-a-child-process convention the file already documents forplugin-opentelemetry's preload tests — worth calling out so a future agent recognizes and reuses it instead of reinventing it.📚 Description
Added one bullet to the "Conventions" section, next to the existing
plugin-opentelemetrypreload-test note, describingplugin-subcommands-advanced'stests/older-framework.test.ts: it readsrunPreconditionsfrom the@wolfstar/http-frameworknamespace at call time (not a named import) so the plugin keeps loading on the parts of its peer range (^3.1.0 || ^5.0.0 || ^6.0.0) that predate framework6.3.0, and it proves this by building the package withtsdownand exec'ing the output in a child Node process — something vitest's own transform would otherwise mask.No other gaps found: commands, scripts, the typecheck consumption-test list, and the release/announce flow all still match what's on
main.Key changes
AGENTS.md: one new bullet under "Conventions" documenting theplugin-subcommands-advancedolder-framework build test as a second instance of the preload-test pattern.Type of Change
Pre-flight Checklist
pnpm changeset(orpnpm changeset add --emptyif no release is needed). See .changeset/README.md.Generated by Claude Code


Confidence Score: 5/5
This documentation-only change appears safe to merge.Reviews (1) · Last reviewed commit: "docs: update AGENTS.md to reflect recent..." · Reviewed by Greptile